Nit/rustc warnings20240222 #159
Merged
Commits on Feb 22, 2024
-
Change the import location of tracing macros in thetawave_storage::us…
…er_stats. Bevy reexports the tracing module rather than reexporting the logging macros in the prelude. The existing import locations for the bevy tracing macros was deprecated/changed in v0.12
-
Rustc started warning more about redundant imports. Remove most of th…
…e redundant imports and make imports more explicit by replacing star imports with each individual item
-
Replace as many star imports as I have patience for with explicit ite…
…m-level imports. Especially modules with many star imports. These have caused more rustc warnings over time. And star imports are generally bad since the pollute the namespace and make imports order-dependent
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.