Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

game crashes if nodebox is nil #3

Closed
berengma opened this issue Oct 6, 2019 · 6 comments
Closed

game crashes if nodebox is nil #3

berengma opened this issue Oct 6, 2019 · 6 comments

Comments

@berengma
Copy link
Contributor

berengma commented Oct 6, 2019

makes a server unplayable because game crashes repeatedly when a mob meets a node with nodebox = nil.

easy solution line 180:
if node.drawtype == 'nodebox' then
if node.node_box == nil then return nil end -- <- This is new and to be added
if node.node_box.type == 'fixed' then

@TheTermos
Copy link
Owner

First I need to investigate why such a node exists, then maybe I'll be able to determine the height instead of making it impassable by returning nil.

Would be grateful if you'd be kind to temporarily add this to your local fix and report the result:

if node.node_box == nil then
minetest.chat_send_all('nodeboxless: '.. node.name)
return nil
end

@berengma
Copy link
Contributor Author

berengma commented Oct 7, 2019

good idea.

i tried to find it with grep yesterday, but failed in using the right parameters and sorting output

@berengma
Copy link
Contributor Author

berengma commented Oct 8, 2019

it is farming_redo on Lilly:

2019-10-07 22:39:00: ACTION[Server]: [mobkit] farming:melon_8 uses nodebox without node_box defined

@TheTermos
Copy link
Owner

Thanks, master updated, please check if it solved the problem.

@berengma
Copy link
Contributor Author

berengma commented Oct 8, 2019

mobkit updated on server, until now it is save, even with players and mobs near melons

@TheTermos
Copy link
Owner

Case closed then, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants