Skip to content
This repository has been archived by the owner on Dec 14, 2021. It is now read-only.

Add Default for BRIDGE_UDP or warn if missing #24

Closed
niondir opened this issue Jul 24, 2018 · 5 comments
Closed

Add Default for BRIDGE_UDP or warn if missing #24

niondir opened this issue Jul 24, 2018 · 5 comments
Assignees

Comments

@niondir
Copy link
Contributor

niondir commented Jul 24, 2018

There should be some log about wrongly/not configured BRIDGE_UDP. Currently it's silently ignored and the bridge is just not working without helpful logs.

@htdvisser
Copy link
Contributor

Thanks for the request. Can you submit a pull request for this?

@niondir
Copy link
Contributor Author

niondir commented Jul 27, 2018

Sure I can. Do you prefere a default + log or just a warning? I'm usually prefere good defaults.

@htdvisser
Copy link
Contributor

I also prefer having sane defaults, which is what we will do with our upcoming v3 stack. For our v2 stack we shouldn't change the defaults, we don't want to silently change the behavior of production deployments.

For now, logging a Warn() about non-configured UDP port is fine. Wrongly configured (port already taken) can log an Error(), possibly even a Fatal().

@niondir
Copy link
Contributor Author

niondir commented Jul 27, 2018

There is no such thing as a working default, since with the current default there is just no UDP connection opened. I think adding a default can not break any environment. Or is there any reason to not have a UDP connection open with the bridge?

@htdvisser
Copy link
Contributor

htdvisser commented Jul 27, 2018

We have seen production deployments with one instance of the bridge responsible for MQTT, and a second for UDP. Changing the default would make the MQTT bridge claim a UDP port, potentially breaking the deployment.

We can't make these kind of changes in a minor update.

htdvisser pushed a commit that referenced this issue Jul 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants