-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metadata API: Remove dependency on dateutil #1722
Comments
I think bump_expiration() as a method is not super useful. Current test code looks like this:
Same thing without using the helper function:
this is in my opinion at least as readable and works fine without the API depending on dateutil. |
This breaks RTD documentation:
|
we don't need to remove the function to fix the immediate issue. Let's fix the dependency issue first, then spend the time we need to get the API (and/or docs) right before 1.0 release: as an example I only now realized the test (and the function) are also bad examples: I don't think anyone ever wants to bump to I suggest we
|
An issue where we can discuss if we want |
PR #1710 added a new package dependency (dateutil) to Metadata API: This was likely not intended, and was not caught by the tests because dateutil is a test dependency.
I think we should fix this before releasing 0.20 (#1694).
The text was updated successfully, but these errors were encountered: