Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Implementations command/code copy-pastable #2637

Closed
h4l0gen opened this issue May 21, 2024 · 4 comments · Fixed by #2642
Closed

Make Implementations command/code copy-pastable #2637

h4l0gen opened this issue May 21, 2024 · 4 comments · Fixed by #2642

Comments

@h4l0gen
Copy link
Contributor

h4l0gen commented May 21, 2024

Please fill in the fields below to submit an issue or feature request. The
more information that is provided, the better.

Description of issue or feature request:
Currently, the implementation command/code is not copy-pastable. Giving an copy option in top right corner of code's box would address this issue. With this, we can pass the CNCF assessment criteria.

Current behavior:
Not copy-pastable

Expected behavior:
Should be copy-pastable.

@h4l0gen
Copy link
Contributor Author

h4l0gen commented May 21, 2024

I will create PR for this.

@h4l0gen
Copy link
Contributor Author

h4l0gen commented May 24, 2024

@JustinCappos what you think on this. As per last point of this criteria of CNCF assessment, we should have copy-pastable code. And we lack in that here.

@jku
Copy link
Member

jku commented May 24, 2024

the implementation command/code is not copy-pastable.

The commands are copy-pastable just fine.

I'm not against adding a copy button if that's easily doable in Sphinx (but adding e.g. new doc build dependencies for this does not sound useful).

@h4l0gen
Copy link
Contributor Author

h4l0gen commented May 24, 2024

Okay, I will give it a try, if that's easy to add, I will create PR. Thankyou.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants