Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix simple typo, excepion -> exception #1298

Merged
merged 1 commit into from
Mar 11, 2021
Merged

docs: fix simple typo, excepion -> exception #1298

merged 1 commit into from
Mar 11, 2021

Conversation

timgates42
Copy link
Contributor

@timgates42 timgates42 commented Mar 3, 2021 •
edited by lukpueh
Loading

There is a small typo in tests/test_roledb.py.

Closes #1262

Please fill in the fields below to submit a pull request. The more information
that is provided, the better.

Fixes #

Description of the changes being introduced by the pull request:

Please verify and check that the pull request fulfills the following
requirements:

  • The code follows the Code Style Guidelines
  • Tests have been added for the bug fix or new feature
  • Docs have been added for the bug fix or new feature

@rzr rzr mentioned this pull request Mar 3, 2021
Closed
mnm678
mnm678 reviewed Mar 4, 2021
View reviewed changes
Copy link
Contributor

@mnm678 mnm678 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Can you fix the DCO?

@timgates42
docs: fix simple typo, excepion -> exception
f0b8b1e 
There is a small typo in tests/test_roledb.py.

Closes #1262

Signed-off-by: Tim Gates <tim.gates@iress.com>
@timgates42
Copy link
Contributor Author

Looks good. Can you fix the DCO?

Thanks done

@rzr
Copy link
Contributor

rzr commented Mar 11, 2021

Please also check my comments about tick boxes:

#1262 (comment)

lukpueh
lukpueh approved these changes Mar 11, 2021
View reviewed changes
Copy link
Member

@lukpueh lukpueh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch, @timgates42.

Please also check my comments about tick boxes:

@rzr, we really don't require the check boxes being ticked off.

@lukpueh lukpueh merged commit 477abc8 into theupdateframework:develop Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnm678 mnm678 mnm678 left review comments

@lukpueh lukpueh lukpueh approved these changes

@rzr rzr rzr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix simple typo: excepion -> exception
4 participants
@timgates42 @rzr @lukpueh @mnm678