Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes imports to be vendoring compatible #1328

Merged

Conversation

avelichka
Copy link
Contributor

Fixes #1316

Fixes imports to be vendoring compatible.
Imports like import tuf.settings that are not compatible with vendoring are replaced with from tuf import settings.

Please verify and check that the pull request fulfills the following
requirements
:

  • The code follows the Code Style Guidelines
  • Tests have been added for the bug fix or new feature
  • Docs have been added for the bug fix or new feature

@avelichka avelichka marked this pull request as ready for review March 31, 2021 14:52
@sechkova
Copy link
Contributor

Thanks for the help, @avelichka!

Can you check the TUF contributor's guidelines so that all checks are successful.
Let us know if you find anything unclear :)

@sechkova sechkova added the experimental-client Items related to the development of a new client (see milestone/8 and theexperimental-client branch) label Mar 31, 2021
Fixes imports to be vendoring compatible

Signed-off-by: Velichka Atanasova <avelichka@vmware.com>
@avelichka avelichka force-pushed the experimental-client branch 2 times, most recently from 3e52968 to 8579e8c Compare April 6, 2021 07:48
Fixes isort issue.

Signed-off-by: Velichka Atanasova <avelichka@vmware.com>
@avelichka
Copy link
Contributor Author

@sechkova, thank you for sharing the TUF contributor's guidelines!

All checks seem to have passed successfully and I'm looking forward to your comments :)
Thank you in advance for any constructive feedback that you might have regarding the change!

Copy link
Contributor

@sechkova sechkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
LGTM but @jku is the vendoring expert nowadays :)

Copy link
Member

@jku jku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@jku jku merged commit ad30da8 into theupdateframework:experimental-client Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
experimental-client Items related to the development of a new client (see milestone/8 and theexperimental-client branch)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants