Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

/competitions vertical alignment issues #2640

Closed
timreyn opened this issue Mar 2, 2018 · 0 comments · Fixed by #2641
Closed

/competitions vertical alignment issues #2640

timreyn opened this issue Mar 2, 2018 · 0 comments · Fixed by #2641
Assignees
@jfly

Comments

@timreyn
Copy link
Contributor

timreyn commented Mar 2, 2018

wca_competitions

The vertical alignment of each row on /competitions is a little weird (on desktop). The competition name is not lined up with the rest of the row.
@jfly jfly self-assigned this Mar 2, 2018
jfly added a commit to jfly/worldcubeassociation.org that referenced this issue Mar 2, 2018
@jfly
Use <p> tags instead of <div> tags in competitions list.
84f5f7b 
This fixes thewca#2640, and I don't believe has any downsides.
@jfly jfly mentioned this issue Mar 2, 2018
Merged
jfly added a commit to jfly/worldcubeassociation.org that referenced this issue Mar 4, 2018
@jfly
Use <div> tags instead of <p> tags in competitions list.
34f886b 
This fixes thewca#2640, and I don't believe has any downsides.
@jfly jfly closed this as completed in #2641 Mar 4, 2018
jfly added a commit that referenced this issue Mar 4, 2018
@jfly
Use <div> tags instead of <p> tags in competitions list.
14d3566 
This fixes #2640, and I don't believe has any downsides.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jfly jfly

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use <div> tags instead of <p> tags in competitions list. jfly/worldcubeassociation.org
2 participants
@jfly @timreyn