Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump css-loader from 2.1.1 to 3.1.0 in /WcaOnRails #4346

Conversation

dependabot-preview[bot]
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented Jul 22, 2019

Bumps css-loader from 2.1.1 to 3.1.0.

Release notes

Sourced from css-loader's releases.

v3.1.0

3.1.0 (2019-07-18)

Bug Fixes

  • converting all (including reserved and control) filesystem characters to - (it was regression in 3.0.0 version) (#972) (f51859b)
  • default context should be undefined instead of null (#965) (9c32885)

Features

  • allow modules.getLocalIdent to return a falsy value (#963) (9c3571c)
  • improved validation error messages (65e4fc0)

v3.0.0

3.0.0 (2019-06-11)

Bug Fixes

  • avoid the "from" argument must be of type string error (#908) (e5dfd23)
  • invert Function behavior for url and import options (#939) (e9eb5ad)
  • properly export locals with escaped characters (#917) (a0efcda)
  • property handle non css characters in localIdentName (#920) (d3a0a3c)

Features

  • modules options now accepts object config (#937) (1d7a464)
  • support @value at-rule in selectors (#941) (05a42e2)

BREAKING CHANGES

  • minimum required nodejs version is 8.9.0
  • @value at rules now support in selector, recommends checking all @values at-rule usage (hint: you can add prefix to all @value at-rules, for example @value v-foo: black; or @value m-foo: screen and (max-width: 12450px), and then do upgrade)
  • invert {Function} behavior for url and import options (need return true when you want handle url/@import and return false if not)
  • exportLocalsStyle option was remove in favor localsConvention option, also it is accept only {String} value (use camelCase value if you previously value was true and asIs if you previously value was false)
  • exportOnlyLocals option was remove in favor onlyLocals option
  • modules option now can be {Object} and allow to setup CSS Modules options:
    • localIdentName option was removed in favor modules.localIdentName option
    • context option was remove in favor modules.context option
    • hashPrefix option was removed in favor modules.hashPrefix option
    • getLocalIdent option was removed in favor modules.getLocalIdent option
    • localIdentRegExp option was removed in favor modules.localIdentRegExp option
Changelog

Sourced from css-loader's changelog.

3.1.0 (2019-07-18)

Bug Fixes

  • converting all (including reserved and control) filesystem characters to - (it was regression in 3.0.0 version) (#972) (f51859b)
  • default context should be undefined instead of null (#965) (9c32885)

Features

  • allow modules.getLocalIdent to return a falsy value (#963) (9c3571c)
  • improved validation error messages (65e4fc0)

3.0.0 (2019-06-11)

Bug Fixes

  • avoid the "from" argument must be of type string error (#908) (e5dfd23)
  • invert Function behavior for url and import options (#939) (e9eb5ad)
  • properly export locals with escaped characters (#917) (a0efcda)
  • property handle non css characters in localIdentName (#920) (d3a0a3c)

Features

  • modules options now accepts object config (#937) (1d7a464)
  • support @value at-rule in selectors (#941) (05a42e2)

BREAKING CHANGES

  • minimum required nodejs version is 8.9.0
  • @value at rules now support in selector, recommends checking all @values at-rule usage (hint: you can add prefix to all @value at-rules, for example @value v-foo: black; or @value m-foo: screen and (max-width: 12450px), and then do upgrade)
  • invert {Function} behavior for url and import options (need return true when you want handle url/@import and return false if not)
  • exportLocalsStyle option was remove in favor localsConvention option, also it is accept only {String} value (use camelCase value if you previously value was true and asIs if you previously value was false)
  • exportOnlyLocals option was remove in favor onlyLocals option
  • modules option now can be {Object} and allow to setup CSS Modules options:
    • localIdentName option was removed in favor modules.localIdentName option
    • context option was remove in favor modules.context option
    • hashPrefix option was removed in favor modules.hashPrefix option
    • getLocalIdent option was removed in favor modules.getLocalIdent option
    • localIdentRegExp option was removed in favor modules.localIdentRegExp option

... (truncated)
Commits
  • 926ebbd chore(release): 3.1.0
  • 5d2c52e test: escaped in selectors (#973)
  • f51859b fix: converting reserved and control filesystem characters to - (#972)
  • 65e4fc0 feat: improved validation error messages
  • 9c32885 fix: default context should be undefined instead of null (#965)
  • 9c3571c feat: allow modules.getLocalIdent to return a falsy value (#963)
  • c4b7f71 chore(release): 3.0.0
  • a50dc48 chore(deps): update (#959)
  • 366d05a feat: exportLocalsStyle was remove in favor new localsConvention (#958)
  • aa75fa7 feat: exportOnlyLocals was remove in favor new onlyLocals option (#957)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it). To ignore the version in this PR you can just close it
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

@AlbertoPdRF
Copy link
Contributor

Probably #4225 (comment) is still relevant.

@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/WcaOnRails/css-loader-3.1.0 branch from 76a2da9 to bf52b9e Compare July 23, 2019 06:36
@dependabot-preview
Copy link
Contributor Author

Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting @dependabot rebase.

@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/WcaOnRails/css-loader-3.1.0 branch from bf52b9e to 991a8e6 Compare July 23, 2019 12:41
@jfly
Copy link
Contributor

jfly commented Jul 29, 2019

I dug a bit, and this looks like it's due to a bug in the webpacker gem. I filed an issue upstream: rails/webpacker#2197.

For now, I think we can

@dependabot-bot ignore this version

Until there's a newer version of webpacker with a fix for this.

@dependabot-preview dependabot-preview bot deleted the dependabot/npm_and_yarn/WcaOnRails/css-loader-3.1.0 branch July 29, 2019 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants