Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add route for full.html.erb regulations #9541

Merged
merged 3 commits into from
Jun 19, 2024
Merged

Add route for full.html.erb regulations #9541

merged 3 commits into from
Jun 19, 2024

Conversation

Nanush7
Copy link
Member

@Nanush7 Nanush7 commented Jun 13, 2024

@Nanush7 Nanush7 mentioned this pull request Jun 13, 2024
Merged
gregorbg pushed a commit to thewca/wca-regulations that referenced this pull request Jun 13, 2024
@Nanush7
Compile merged Regulations and Guidelines (#1199)
df303bd 
Add html with the merged flag.

The new option generates a `full.html.erb` file in the output dir. So
now we have three html files, two for the separated documents and one
for the merged version.

See thewca/worldcubeassociation.org#9541 and
thewca/wca-regulations-compiler#28.
@Nanush7 Nanush7 mentioned this pull request Jun 13, 2024
Merged
gregorbg pushed a commit to thewca/wca-regulations that referenced this pull request Jun 14, 2024
@Nanush7
Compile merged Regulations and Guidelines (#1200)
e66805e 
Add html with the merged flag.

The new option generates a `full.html.erb` file in the output dir. So
now we have three html files, two for the separated documents and one
for the merged version.

See thewca/worldcubeassociation.org#9541 and
thewca/wca-regulations-compiler#28.
@gregorbg
Copy link
Member

The files are now hosted on S3, yay!

gregorbg
gregorbg approved these changes Jun 14, 2024
View reviewed changes
Copy link
Member

@gregorbg gregorbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with the change as-is, you might want to add a dropdown menu option so that users can actually navigate to the new file?

Code is at app/views/layouts/_navigation.html.erb somewhere around line 80-ish

@Nanush7
Copy link
Member Author

Nanush7 commented Jun 14, 2024

Yes! We want that :)

Any ideas for the icon?

@gregorbg
Copy link
Member

Be my guest: https://fontawesome.com/v4/icons/

My spontanenous suggestions: cc, support, plus square

@Nanush7
Copy link
Member Author

Nanush7 commented Jun 14, 2024

What about plus-square for the Guidelines, file-text (this one is used in the information dropdown menu too) for the Regulations and leave the current book for the full version?

For the text, does "Regulations & Guidelines" look good?

@gregorbg
Copy link
Member

What about plus-square for the Guidelines, file-text (this one is used in the information dropdown menu too) for the Regulations and leave the current book for the full version?

For the text, does "Regulations & Guidelines" look good?

Quite honestly, I'm not the person to make this decision. I only have the authority over technical implementation details, but the community (or at least the WRC) should be the one to make this design decision.

@Nanush7
Copy link
Member Author

Nanush7 commented Jun 19, 2024

@gregorbg Done!

@gregorbg gregorbg merged commit 5fe67da into thewca:main Jun 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregorbg gregorbg gregorbg approved these changes

Assignees

@Nanush7 Nanush7

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Nanush7 @gregorbg