Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile merged Regulations and Guidelines #1200

Merged
merged 1 commit into from
Jun 14, 2024
Merged

Compile merged Regulations and Guidelines #1200

merged 1 commit into from
Jun 14, 2024

Conversation

Nanush7
Copy link
Member

@Nanush7 Nanush7 commented Jun 13, 2024

Add html with the merged flag.

The new option generates a full.html.erb file in the output dir. So now we have three html files, two for the separated documents and one for the merged version.

See thewca/worldcubeassociation.org#9541 and thewca/wca-regulations-compiler#28.

Add html with the merged flag.

The new option generates a `full.html.erb` file in the output dir. So
now we have three html files, two for the separated documents and one
for the merged version.

See thewca/worldcubeassociation.org#9541 and
thewca/wca-regulations-compiler#28.
@Nanush7 Nanush7 self-assigned this Jun 13, 2024
@Nanush7 Nanush7 requested a review from a team as a code owner June 13, 2024 22:07
@Nanush7 Nanush7 changed the title Compile merged Regulations and Guidelines (#1199) Compile merged Regulations and Guidelines Jun 13, 2024
@lgarron
Copy link
Member

lgarron commented Jun 14, 2024

The new option generates a full.html.erb file in the output dir. So now we have three html files, two for the separated documents and one for the merged version.

I didn't catch that name until now — do you think it would be easy to switch to merged.html.erb?

I think "full" implies that either of the merged documents is "partial", which isn't really accurate.

@gregorbg
Copy link
Member

I didn't catch that name until now — do you think it would be easy to switch to merged.html.erb?

I think "full" implies that either of the merged documents is "partial", which isn't really accurate.

Switching the name requires an update to the Python WRC-compiler, which is easy enough. It won't require another code change in this repository, just a new trigger of the GH Action with the updated wrc version.

@gregorbg gregorbg merged commit e66805e into official Jun 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants