We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The base.html of the Django admin has a textbook accessibility fail – disabling zooming for mobile users: https://github.com/django/django/blob/278b6187d2a6711afb0b35dc5c3c09fe5be9adb3/django/contrib/admin/templates/admin/base.html#L15
base.html
This is what the meta_viewport rule is meant to pick up, unfortunately it doesn’t pick it up.
meta_viewport
viewport, meta, user-scalable
$ curlylint --version curlylint, version 0.12.0
macOS Catalina
$ curlylint --rule 'meta_viewport: true' admin/templates/admin/base.html admin/templates/admin/base.html 14:1 Remove `user-scalable=no` from the viewport meta so users can zoom meta_viewport Oh no! 💥 💔 💥 1 error reported
$ curlylint --rule 'meta_viewport: true' admin/templates/admin/base.html All done! ✨ 🍰 ✨
The problem seems to be with the meta tag being inside of a block:
{% block responsive %} <meta name="viewport" content="user-scalable=no, width=device-width, initial-scale=1.0, maximum-scale=1.0"> <link rel="stylesheet" type="text/css" href="{% static "admin/css/responsive.css" %}"> {% if LANGUAGE_BIDI %}<link rel="stylesheet" type="text/css" href="{% static "admin/css/responsive_rtl.css" %}">{% endif %} {% endblock %}
Moving it out of the block, the issue is picked up correctly.
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Describe the bug
The
base.html
of the Django admin has a textbook accessibility fail – disabling zooming for mobile users: https://github.com/django/django/blob/278b6187d2a6711afb0b35dc5c3c09fe5be9adb3/django/contrib/admin/templates/admin/base.html#L15This is what the
meta_viewport
rule is meant to pick up, unfortunately it doesn’t pick it up.Which terms did you search for in the documentation and issue tracker?
viewport, meta, user-scalable
Environment
macOS Catalina
Steps to reproduce
Expected behavior
Actual behavior
The problem seems to be with the meta tag being inside of a block:
Moving it out of the block, the issue is picked up correctly.
The text was updated successfully, but these errors were encountered: