Get account data improvement (#243)

* merge Address & input, get rid of security param (move it to seed & address), cleanup some params, update tests

* update documentation [ci skip]

* add tests

* remove invalid extended function, add optional parameters, remove invalid parameters, improve extended documentation, update tests, ...

* update doxygen doc [ci skip]

* address PR comments

* fix getTransfer [ci skip]

* improve getAccountData performance

* address #194 though, unfortunately, the improvement is negligible

* bundleFromAddresses improvement

* fix build compilation

* initialize hash_ (bundle::getHash) whenever it is possible

docs/html/class_i_o_t_a_1_1_a_p_i_1_1_extended-members.html

@@ -85,7 +85,7 @@
   <tr class="even"><td class="entry"><a class="el" href="class_i_o_t_a_1_1_a_p_i_1_1_extended.html#a93356e4fafc265bb4e3974c9ed74f521">findTransactionsByApprovees</a>(const std::vector&lt; Types::Trytes &gt; &amp;approvees) const</td><td class="entry"><a class="el" href="class_i_o_t_a_1_1_a_p_i_1_1_extended.html">IOTA::API::Extended</a></td><td class="entry"></td></tr>
   <tr><td class="entry"><a class="el" href="class_i_o_t_a_1_1_a_p_i_1_1_extended.html#a51c3e80e5cd620fbeaf43a854b68a674">findTransactionsByBundles</a>(const std::vector&lt; Types::Trytes &gt; &amp;bundles) const</td><td class="entry"><a class="el" href="class_i_o_t_a_1_1_a_p_i_1_1_extended.html">IOTA::API::Extended</a></td><td class="entry"></td></tr>
   <tr class="even"><td class="entry"><a class="el" href="class_i_o_t_a_1_1_a_p_i_1_1_extended.html#a72f943cddf154a2d7937f2db5f86ee56">findTransactionsByTags</a>(const std::vector&lt; Models::Tag &gt; &amp;tags) const</td><td class="entry"><a class="el" href="class_i_o_t_a_1_1_a_p_i_1_1_extended.html">IOTA::API::Extended</a></td><td class="entry"></td></tr>
-  <tr><td class="entry"><a class="el" href="class_i_o_t_a_1_1_a_p_i_1_1_extended.html#a356cfd7e580df1fd4fbef8179e076950">getAccountData</a>(const Models::Seed &amp;seed, int start=0, int end=0, bool returnAll=true, bool inclusionStates=true, long threshold=0) const</td><td class="entry"><a class="el" href="class_i_o_t_a_1_1_a_p_i_1_1_extended.html">IOTA::API::Extended</a></td><td class="entry"></td></tr>
+  <tr><td class="entry"><a class="el" href="class_i_o_t_a_1_1_a_p_i_1_1_extended.html#a0c2a392442d0aed76b3836ab5f41b861">getAccountData</a>(const Models::Seed &amp;seed, int start=0, int end=0, bool inclusionStates=true, long threshold=0) const</td><td class="entry"><a class="el" href="class_i_o_t_a_1_1_a_p_i_1_1_extended.html">IOTA::API::Extended</a></td><td class="entry"></td></tr>
   <tr class="even"><td class="entry"><a class="el" href="class_i_o_t_a_1_1_a_p_i_1_1_core.html#a7d38a82597732a931a927faf4fbdddc0">getBalances</a>(const std::vector&lt; Models::Address &gt; &amp;addresses, const int &amp;threshold=100) const</td><td class="entry"><a class="el" href="class_i_o_t_a_1_1_a_p_i_1_1_core.html">IOTA::API::Core</a></td><td class="entry"></td></tr>
   <tr><td class="entry"><a class="el" href="class_i_o_t_a_1_1_a_p_i_1_1_extended.html#a0c7745f7cefc2d5748b1ac7407f5bad0">getBalancesAndFormat</a>(const std::vector&lt; Models::Address &gt; &amp;addresses, const int64_t &amp;threshold=0) const</td><td class="entry"><a class="el" href="class_i_o_t_a_1_1_a_p_i_1_1_extended.html">IOTA::API::Extended</a></td><td class="entry"></td></tr>
   <tr class="even"><td class="entry"><a class="el" href="class_i_o_t_a_1_1_a_p_i_1_1_extended.html#aae0bbe508888acfe6f97aca3d9e0da86">getBundle</a>(const Types::Trytes &amp;transaction) const</td><td class="entry"><a class="el" href="class_i_o_t_a_1_1_a_p_i_1_1_extended.html">IOTA::API::Extended</a></td><td class="entry"></td></tr>
@@ -109,9 +109,10 @@
   <tr class="even"><td class="entry"><a class="el" href="class_i_o_t_a_1_1_a_p_i_1_1_extended.html#a58a127282d2f4d9e8dff38a74eb70d67">sendTrytes</a>(const std::vector&lt; Types::Trytes &gt; &amp;trytes, const unsigned int &amp;depth, const unsigned int &amp;minWeightMagnitude) const</td><td class="entry"><a class="el" href="class_i_o_t_a_1_1_a_p_i_1_1_extended.html">IOTA::API::Extended</a></td><td class="entry"></td></tr>
   <tr><td class="entry"><a class="el" href="class_i_o_t_a_1_1_a_p_i_1_1_core.html#a31fc2694189aacb9b1f55a1664661b84">storeTransactions</a>(const std::vector&lt; Types::Trytes &gt; &amp;trytes) const</td><td class="entry"><a class="el" href="class_i_o_t_a_1_1_a_p_i_1_1_core.html">IOTA::API::Core</a></td><td class="entry"></td></tr>
   <tr class="even"><td class="entry"><a class="el" href="class_i_o_t_a_1_1_a_p_i_1_1_extended.html#a7b5c4d33e956c0d76f98aa5a7a1c6f8f">traverseBundle</a>(const Types::Trytes &amp;trunkTx) const</td><td class="entry"><a class="el" href="class_i_o_t_a_1_1_a_p_i_1_1_extended.html">IOTA::API::Extended</a></td><td class="entry"></td></tr>
-  <tr><td class="entry"><a class="el" href="class_i_o_t_a_1_1_a_p_i_1_1_extended.html#a395484ad3ff8c373adb8c981b4f79cd3">traverseBundle</a>(const Types::Trytes &amp;trunkTx, Types::Trytes bundleHash, Models::Bundle &amp;bundle) const</td><td class="entry"><a class="el" href="class_i_o_t_a_1_1_a_p_i_1_1_extended.html">IOTA::API::Extended</a></td><td class="entry"></td></tr>
-  <tr class="even"><td class="entry"><a class="el" href="class_i_o_t_a_1_1_a_p_i_1_1_core.html#a77c19113fb5e0f7a0a74b992e955ffce">~Core</a>()=default</td><td class="entry"><a class="el" href="class_i_o_t_a_1_1_a_p_i_1_1_core.html">IOTA::API::Core</a></td><td class="entry"><span class="mlabel">virtual</span></td></tr>
-  <tr><td class="entry"><a class="el" href="class_i_o_t_a_1_1_a_p_i_1_1_extended.html#ae292873ec0cd8936d28e7ffe95cb6c83">~Extended</a>()=default</td><td class="entry"><a class="el" href="class_i_o_t_a_1_1_a_p_i_1_1_extended.html">IOTA::API::Extended</a></td><td class="entry"><span class="mlabel">virtual</span></td></tr>
+  <tr><td class="entry"><a class="el" href="class_i_o_t_a_1_1_a_p_i_1_1_extended.html#a3b565d6b213f44ac1bf2a8348d1c1a01">traverseBundles</a>(const std::vector&lt; Types::Trytes &gt; &amp;trunkTrxs, bool throwOnFail=true) const</td><td class="entry"><a class="el" href="class_i_o_t_a_1_1_a_p_i_1_1_extended.html">IOTA::API::Extended</a></td><td class="entry"></td></tr>
+  <tr class="even"><td class="entry"><a class="el" href="class_i_o_t_a_1_1_a_p_i_1_1_extended.html#a2ec2d0dfeb48ffccdc4d526e2e137729">verifyBundle</a>(const Models::Bundle &amp;bundle) const</td><td class="entry"><a class="el" href="class_i_o_t_a_1_1_a_p_i_1_1_extended.html">IOTA::API::Extended</a></td><td class="entry"></td></tr>
+  <tr><td class="entry"><a class="el" href="class_i_o_t_a_1_1_a_p_i_1_1_core.html#a77c19113fb5e0f7a0a74b992e955ffce">~Core</a>()=default</td><td class="entry"><a class="el" href="class_i_o_t_a_1_1_a_p_i_1_1_core.html">IOTA::API::Core</a></td><td class="entry"><span class="mlabel">virtual</span></td></tr>
+  <tr class="even"><td class="entry"><a class="el" href="class_i_o_t_a_1_1_a_p_i_1_1_extended.html#ae292873ec0cd8936d28e7ffe95cb6c83">~Extended</a>()=default</td><td class="entry"><a class="el" href="class_i_o_t_a_1_1_a_p_i_1_1_extended.html">IOTA::API::Extended</a></td><td class="entry"><span class="mlabel">virtual</span></td></tr>
 </table></div><!-- contents -->
 <!-- start footer part -->
 <hr class="footer"/><address class="footer"><small>