-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get account data improvement #243
Conversation
…ddress), cleanup some params, update tests
…alid parameters, improve extended documentation, update tests, ...
I also addressed #194, but turns out it does not improve much (tried different seeds). |
Please do not merge immediately, still doing some experiments. |
Just addressed #194 optimization comment. It now goes as fast as Java library and can go a little bit faster by doubling the number of threads in the parallel_for. Before merging this issue, I will check some places where we can initialize the hash in Models::Bundle (I added Models::Bundle::getHash and Models::Bundle::setHash to improve API & code clarity). |
Small improvement of getAccountData.
The improvement results in twice as fast on testing data (as demonstrated by the screenshot below).
The improvement should be more significant for accounts with a large number of addresses.
Before:
After: