-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename columns that changed in a recent update #103
Conversation
Kudos, SonarCloud Quality Gate passed! |
Test this for my app and it works fine! thanks, I hope it will get merged 😊 |
@AlexanderWillner I'm not sure who the right person is to bring this up with, but the library currently will not function without these changes. Is there anything I can do to help move this along? (If you're not the correct person to ping, is there someone else I can ask?) 🙏🏻 |
@CaAlden Is there any way for me to use these changes locally on things-cli? (sorry if this is a naive question 🙈) |
It might not be the simplest thing, but you could get something working if you checkout I basically did |
Thanks - I'll make the needed changes in all repositories |
Thanks for the detailed response @CaAlden! Thanks @AlexanderWillner, looking forward to it! |
@AlexanderWillner It looks like the tests are failing because the |
It's the actual test Things DB (Things is using sqlite). What is needed is to open the main.sqlite file with the current version of Things and save it again. The commands All can be figured out, just needs a few minutes/hours... |
@CaAlden Thank you for the heads-up and the fast pull request. Also, thank you for your patience these weeks until we got back to you. An important note (also, /cc @AlexanderWillner): we might need to check what Things version the user has; it seems not all are automatically upgraded. I'm on Big Sur (which is still actively supported) and Things is at Version 3.15.16 and For comparison (on Big Sur with Version 3.15.16):
The SQL query might be formed conditionally based on database version. |
Follow-up and new idea. Instead of implementing backwards-compatible support, do this:
That keeps the code clean. |
See thingsapi/things.py#103 Thanks to Phil R.!
See thingsapi/things.py#103 Thanks to Phil R.!
See thingsapi/things.py#103 Thanks to Phil R.!
See thingsapi/things.py#103 Thanks to Phil R.!
I looks like the problem is solved. I hope that non-developers like myself can soon use Things CLI again by simply upgrading the pip package! 🤞 I'm on macOS 13.3.1 (a) (22E772610a) and Things 3.17.7 (31707500). |
Do we know in which DB version the changes happened? We could start with using version 21 as the breaking point... |
Sounds good to me. We can always fix it later if needed. |
@AlexanderWillner Ping ;) |
Partly solved, thanks for the contributions! Next step(s) to be discussed in #110 |
After a recent update to things, the database was moved and some of the columns in the
TMTask
table were renamed. See discussion on the ticket: #100There is another problem that the database has also moved. The issue suggests exporting a custom
THINGSDB
environment variable, but because this PR does not address that issue, I don't feel comfortable marking that issue as resolved by this.Also, hello! This is my first time contributing. Please let me know if there's anything you would like me to do to make this PR match the project's standards in some way. I didn't see a readme for contributing.