Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes in DB version 24 #110

Closed
3 tasks done
AlexanderWillner opened this issue May 21, 2023 · 2 comments
Closed
3 tasks done

Changes in DB version 24 #110

AlexanderWillner opened this issue May 21, 2023 · 2 comments

Comments

@AlexanderWillner
Copy link
Contributor

AlexanderWillner commented May 21, 2023 •
edited by mikez
Loading

As discussed in #100, #101, #102 and addressed in #103, #105, #106, #107 the Things DB changed on Apr 13, 2023 in several ways:

Due to the change in the date format the tests do not pass anymore:

% make test
.........F..........F.F..F
test_deadlines
AssertionError: 3 != 4

test_tags
AssertionError: 1 != 0

test_today
AssertionError: 4 != 6

test_upcoming
AssertionError: 1 != 0

FAILED (failures=4)
This was referenced May 21, 2023
Merged
Closed
Closed
Closed
mikez added a commit that referenced this issue May 22, 2023
@mikez
Add support for the new Things integer dates. See #110 and #98.
e64bea8 
A _Things date_ is an integer where the binary digits are
YYYYYYYYYYYMMMMDDDDD0000000; Y is year, M is month, and D is day.

For example, the ISO 8601 date '2021-03-28' corresponds to the Things
date 132464128 as integer; in binary that is:

```
111111001010011111000000000
YYYYYYYYYYYMMMMDDDDD0000000
       2021   3   28
```
@mikez
Copy link
Contributor

mikez commented May 22, 2023

@AlexanderWillner Added support for new dates.

One seemingly unrelated test involving tags in test_tags is failing. Is this due to a changed database?

@AlexanderWillner
Copy link
Contributor Author

All green now in #112

@mikez mikez mentioned this issue May 22, 2023
Closed
@mikez mikez changed the title Date format changed in DB version 24 Changes in DB version 24 May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mikez @AlexanderWillner