Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v2 Market contract: direct listing + english auction #20

Closed
nkrishang opened this issue Nov 8, 2021 · 2 comments · Fixed by #39
Closed

v2 Market contract: direct listing + english auction #20

nkrishang opened this issue Nov 8, 2021 · 2 comments · Fixed by #39
Assignees
@nkrishang
Labels
enhancement New feature or request

Comments

@nkrishang
Copy link
Contributor

No description provided.

@nkrishang nkrishang self-assigned this Nov 8, 2021
@nkrishang nkrishang added the enhancement New feature or request label Nov 8, 2021
@nkrishang
Copy link
Contributor Author

First full draft of v2 Market - https://github.com/nftlabs/nftlabs-protocols/tree/dev/contracts/v2

@nkrishang
Copy link
Contributor Author

Project status

What's done -

In Progress -

  • Design doc for the contract. The doc uses internal language and shorthands. It needs to be updated for handing off to the rest of the team, and be published on the thirdweb portal.
  • Tests for common security vulnerabilities beyond basic unit tests.
  • Set up tests with a smart contract fuzzer (current candidate: echidna)

@nkrishang nkrishang linked a pull request Dec 6, 2021 that will close this issue
V2 market - first implementation + tests #39
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nkrishang nkrishang

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

V2 market - first implementation + tests thirdweb-dev/contracts
1 participant
@nkrishang