Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tabs on the front page don't work right #2

Closed
Traumflug opened this issue Jun 23, 2019 · 3 comments
Closed

Tabs on the front page don't work right #2

Traumflug opened this issue Jun 23, 2019 · 3 comments

Comments

@Traumflug
Copy link
Contributor

There are three tabs, New arrivals, Popular and Best sellers.

  • Clicking on Popular apparently does nothing.
  • Clicking on Best sellers removes the part above Our featured products and appends best sellers below this section, without heading. Which then looks like no best sellers, but twice as many featured products.
@Dh42
Copy link
Contributor

Dh42 commented Jun 23, 2019

These two commits should fix the home featured part

thirtybees/homefeatured@ccd73c3

f3d94ae

For the best sellers I think we need to populate information to the database.

@Dh42
Copy link
Contributor

Dh42 commented Jun 23, 2019

Actually it looks like fixing that template also fixed the best sellers too, I call that a win.

@Dh42
Copy link
Contributor

Dh42 commented Jun 26, 2019

They should be working now. I am going to close this, I am going to commit using rows instead of tabs on the home page as well. Just to keep it cleaner and more modern.

@Dh42 Dh42 closed this as completed Jun 26, 2019
@getdatakick getdatakick mentioned this issue Jul 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Traumflug @Dh42