Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please update the underlying ACE implementation #148

Closed
StoneCypher opened this issue Dec 7, 2018 · 6 comments
Closed

Please update the underlying ACE implementation #148

StoneCypher opened this issue Dec 7, 2018 · 6 comments

Comments

@StoneCypher
Copy link
Contributor

Hello and thanks for this high quality library

Would you please bump to 1.4.2? There's some important changes and a language I'd like to pick up.

If you wrote out instructions on how to bump, we could submit bumps for you.

I joined your patreon at $10 to try to motivate you 😃

Please have a good day.

@StoneCypher
Copy link
Contributor Author

@thlorenz - or if you'd tell us how to do it, I'd do it

@tankbusta
Copy link

@StoneCypher Instructions on how to bump the version are included in the README which is what was done in PR #139. Unfortunately, you'll have to fork the repository, bump the version in the updater script, and publish your fork if you want something simple like yarn install brace (unless @thlorenz comes back and automates this process). This is what I did to get 1.4.2

@StoneCypher
Copy link
Contributor Author

ffffffffffffffffffffffffffffffffffffffffun. (no i use npm because i'm allergic to new things.)

so it's the update script and that's it? cool. thanks, @tankbusta

@tankbusta
Copy link

Ha. It doesn't matter if it's yarn or npm, the steps are still the same.

You just need to change update.js to 1.4.2 (or whatever version you want) and run the update script (defined by package.json) with npm run update . Granted I don't use all of (br)ace's functionality but I haven't ran into any issues.

@StoneCypher
Copy link
Contributor Author

Got it. Thanks again, destroyer of tanks.

#151

@StoneCypher
Copy link
Contributor Author

#153

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants