Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

w3c-blob not working with (br)ace 1.2.3 #64

Closed
prasikumbhare opened this issue Sep 8, 2016 · 9 comments
Closed

w3c-blob not working with (br)ace 1.2.3 #64

prasikumbhare opened this issue Sep 8, 2016 · 9 comments

Comments

@prasikumbhare
Copy link

w3c-blob isn't working for me on Chome. Had to comment it out. Instead using the standard Blob api works :).. So i think the w3c-blob api should be removed or at least first a check for standard Blob api should be added..

@AStoker
Copy link

AStoker commented Dec 5, 2016

Bump. Any update on this?

@thlorenz
Copy link
Owner

thlorenz commented Dec 7, 2016

I'm not fully aware what's broken WRT w3c-blob. Could you elaborate a bit more please?
Have you tried upgrading the version of it?

What solution do you propose to replace it while keeping things working in all browsers?
Could you submit a PR with that solution?

@AStoker
Copy link

AStoker commented Dec 7, 2016

Well, my particular problem comes from a bundling operation that fails to find the w3c blob library (probably due to how it's being loaded?). But Blob has support in all browsers (http://caniuse.com/#feat=blobbuilder) at this point, and w3c blob hasn't been updated in 4 years (no recent version). The solution would be to just remove w3c-blob as a dependency and rely on the native browser Blob implementation.

@thlorenz
Copy link
Owner

thlorenz commented Dec 7, 2016

The solution would be to just remove w3c-blob as a dependency and rely on the native browser Blob implementation

That might work for you but would break some people still running with older browsers.

w3c blob hasn't been updated in 4 years

That's cause it is very simple and works and thus needs no updating

If brace is not finding the blob library it could be due to not being properly installed as a dependency?

I'm not sure .. are you using browserify and run npm install and such?
It's odd that you're the only ones with this problem and it works for everyone else.

@AStoker
Copy link

AStoker commented Dec 7, 2016

I know my problem is a bit unique due to the module loader I'm using and the build tools (Aurelia and Aurelia CLI). The reason I pinged this question was because it was "related" in the sense that the library seemed unnecessary. If there's a need for w3c blob, I'm not gonna ask for it to be removed :)

How far back do you need to support?

@thlorenz
Copy link
Owner

thlorenz commented Dec 7, 2016

I know my problem is a bit unique due to the module loader I'm using and the build tools (Aurelia and Aurelia CLI)

OK so brace is only made for use with browserify .. if your module loader doesn't play well with how node + npm + browserify works then you should file an issue there.

How far back do you need to support?

I don't have that data, but would like to not break users on older browsers and would like to not degrade on compatibility.

Please find another solution, i.e. use a module loader that works and/or fork brace and make a custom adaptation just for your broken (sorry) use case ;)

@AStoker
Copy link

AStoker commented Dec 7, 2016

Sure thing. I wasn't trying to claim that this was broken :) Was just bumping the original question to try and figure something out. Thanks for responding.

@thlorenz
Copy link
Owner

thlorenz commented Dec 7, 2016

Yeah, I understood that .. next time it would help to clarify that you aren't using a lib the way it is intended to be used, i.e. it states clearly in the readme that it is for browserify.
That way I don't have to spend the time teasing out of you what the actual problem is (in this case your custom loader).

Hope you can figure your problem out ... good luck! :)

@thlorenz thlorenz closed this as completed Dec 7, 2016
@AStoker
Copy link

AStoker commented Dec 7, 2016

Sorry to use your time! Not sure if @prasikumbhare ever solved his problem though :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants