Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Themes #12

Closed
thmarx opened this issue Oct 7, 2023 · 3 comments · Fixed by #73
Closed

Themes #12

thmarx opened this issue Oct 7, 2023 · 3 comments · Fixed by #73
Milestone

Comments

@thmarx
Copy link
Collaborator

thmarx commented Oct 7, 2023

Support for themes

@thmarx
Copy link
Collaborator Author

thmarx commented Nov 7, 2023

Theme support will be hard to do or feel half baked. Reason is the support or multiple template engines. Themes should work with all of theme. I think that is nearly impossible

@thmarx
Copy link
Collaborator Author

thmarx commented Nov 8, 2023

Lightweight theme

Themes provide only styles, javascript and maybe some templates

heavyweight theme

Themes contains styles, javascript, extensions and modules

Global installation or per site?

@thmarx thmarx added this to the 2.7.0 milestone Nov 12, 2023
@thmarx
Copy link
Collaborator Author

thmarx commented Nov 12, 2023

The theme is responsible for telling what template engine is used. If the site config wants another engine, an error will be thrown and the site cannot be loaded.

thmarx added a commit that referenced this issue Nov 12, 2023
thmarx added a commit that referenced this issue Nov 12, 2023
thmarx pushed a commit that referenced this issue Nov 13, 2023
thmarx pushed a commit that referenced this issue Nov 13, 2023
thmarx pushed a commit that referenced this issue Nov 13, 2023
thmarx pushed a commit that referenced this issue Nov 13, 2023
thmarx pushed a commit that referenced this issue Nov 13, 2023
thmarx pushed a commit that referenced this issue Nov 13, 2023
thmarx pushed a commit that referenced this issue Nov 13, 2023
thmarx pushed a commit that referenced this issue Nov 13, 2023
thmarx pushed a commit that referenced this issue Nov 13, 2023
thmarx pushed a commit that referenced this issue Nov 13, 2023
thmarx pushed a commit that referenced this issue Nov 13, 2023
thmarx pushed a commit that referenced this issue Nov 14, 2023
@thmarx thmarx linked a pull request Nov 14, 2023 that will close this issue
thmarx added a commit that referenced this issue Nov 14, 2023
* #12 refactoring properties

* #12 add simple template theme support

* #12 template loader for themes, priority in site templates

* #12 add theme support

* #12 add theme support

* #12 add theme support

* #12 add theme support

* #12 add theme support

* #12 theme example

* #12 add js and style to theme rendering

* #12 load extensions from theme

* #12 some code clean up

* #12 some code clean up

* #12 more code cleanup and simplification

* add changelog

* Update README.md

* #12 update readme

* update release version

* prepare release 2.7.0

---------

Co-authored-by: Thorsten Marx <t.marx@eggheads.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant