Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Tracer vs logger #11

Closed
gianarb opened this issue Nov 14, 2019 · 2 comments
Closed

Question: Tracer vs logger #11

gianarb opened this issue Nov 14, 2019 · 2 comments

Comments

@gianarb
Copy link

gianarb commented Nov 14, 2019

Hello!

My focus atm is on instrumentation, I wrote my logger and my tracer using zap. It is kind of working I think, but I do not understand the difference. Looking at the Tracer and how it is used in queue.go it logs and that's it. I would like to do a trace such as OpenTracing, OpenTeletry. Do you have any suggestions? I think I can do a mix of middleware/event but I would like to get a direction from you.

Thanks a lot

@thoas
Copy link
Owner

thoas commented Nov 19, 2019

Sorry for the late reply, the Tracer is only responsible to report errors (think sentry) and the logger is an internal component to log internal events of bokchoy.

You can disable the internal logger and keep the tracer, that's why there are completely different components.

I hope I answered your question, don't hesitate if it's not the case.

@thoas thoas closed this as completed Nov 19, 2019
@gianarb
Copy link
Author

gianarb commented Nov 20, 2019

Thanks for the explanation.
Do you have any suggestion about how I can/should instrument this library with opentracing or similar?! Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants