-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compile times degraded on using Hecke #111
Comments
Thanks for the report. Which julia version is this? P.S.: The FreeModules provided by AbstractAlgebra are inherently type unstable and prone to problems with inference/compilation (try having a look at |
This is Julia 1.5.3 on Fedora. But I don't think they modify upstream. I didn't know about |
Thanks for the version. Be careful, |
The inference fix has been merged in AA. I will close this for now @martinra. Feel free to open another issue if you encounter this again. These slowdowns hint at some non-optimal code on our side. |
I started to investigate some of my compile times, and tracked down the following issue to Hecke.
Not using Hecke
Using Hecke
I'm not sufficiently deep into the code base to find the source, but I can provide some experience from a similar phenomenon that I discovered in my own code. The compile time exploded in the same way. I had a function of the shape
which caused Julia type interference to almost break down. My fix was
I believe I didn't have these problems in Julia 1.4, but I haven't double checked this. In any case, the work around is not great, but 180s is neither.
The text was updated successfully, but these errors were encountered: