-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
subfields of absolute number fields #46
Comments
Thanks and good catch. Did you enconter an actual error? Just curious. We will have a look soonish. |
After discovering the Hecke implementation, I didn't dare using it given that "Claus says its wrong". |
@martinra We would love to take your version either by PR or just as a snippet here. But we would need to fit it into the generator/basis setting, i.e., it would have to replace the |
Just to make sure, You seem to have a number of tests for |
Yes, correct, thanks!
More tests are of course always welcome :) |
The computation of subfields of absolute number fields seems to be incorrect according to a TODO note in the source code. Ignorant of the subfield implementation I wrote one myself. If you like, I can split up the code below to fit it into the basis/generators distinction currently used in Hecke. If you prefer to fix the current implementation, just close this issue; it's my way of asking whether you are interested in that code.
The text was updated successfully, but these errors were encountered: