Handle ip addresses

[remusao]

Hi,

Currently we don't detect if a url contains a hostname or an ip address. We should probably add some check so that we return a consistent result.

Current behavior:

> tldjs.parse('https://123.23.32.31')
{ valid: true,
  hostname: '123.23.32.31',
  suffix: '31',
  domain: '32.31',
  subdomain: '123.23' }

Should probably be something like:

> tldjs.parse('https://123.23.32.31')
{ valid: true,
  hostname: '123.23.32.31',
  suffix: null,
  domain: null, // Or `hostname`?
  subdomain: null }

[thom4parisot]

Oh, good thinking. I never tried with an IPv6 too but I suppose its syntax would fail on an isValid call.

[remusao]

What do you think about including some dependency to do this validation? I saw two libraries looking pretty robust:

• https://www.npmjs.com/package/validator (does much more than ip-validation, so that might be overkill)
• https://www.npmjs.com/package/is-ip (only based on regexps, which looks pretty fast and robust)

[thom4parisot]

Well, validator has no dependency, has isDataURI andisEmail (cf. #101).
But the rest is not relevant so it is less nice, bundle size wise.

PS: funnily, it has a isFQDN method 😉

[remusao]

So did I understand correctly that we should use is-ip instead? Or do you think it's worth it to integrate also checks for isEmail and isDataURI?

PS: funnily, isFQDN is 10x slower than isValid :P

[thom4parisot]

Yeah let's go ahead with is-ip. We can swap it with something else if needed in the future.

PS: 😂

[remusao]

@oncletom I started adding the support for ip addressed in tld.js. Will do a PR when it's ready. I might also try to switch to whatwg-url for parsing if it works out fine.

[remusao]

IP addresses are now detected since #108.