Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getDomain without subdomains returns with http:// #45

Closed
bortexz opened this issue Sep 15, 2014 · 2 comments
Closed

getDomain without subdomains returns with http:// #45

bortexz opened this issue Sep 15, 2014 · 2 comments

Comments

@bortexz
Copy link

bortexz commented Sep 15, 2014

Hi,

If founded that if getDomain is called with an url without any subdomain, the result of getDomain also has 'http://'

For example,

http://www.google.com will return google.com
but
http://google.com will return http://google.com

In the second case, i think google.com may be returned. Is this intended?

@bortexz bortexz changed the title getDomain with subdomains returns with http:// getDomain without subdomains returns with http:// Sep 15, 2014
@bortexz
Copy link
Author

bortexz commented Sep 15, 2014

Just figured out that this is solved in the last version, i was using an older version.

@bortexz bortexz closed this as completed Sep 15, 2014
@thom4parisot
Copy link
Owner

Good to know it has been fixed meanwhile by #41 even though it was not related directly to the scheme prefix.

Let me know if you encounter any other issue :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants