Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature suggestion: return result object instead of boolean and allow use of identifiers for compare value #5

Open
itailulu opened this issue Jan 16, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@itailulu
Copy link

Currently the tree execution returns a boolean, and there's no way to trace what was the result for each node. I suggest to return a NodeResult object instead, holding both the boolean result, and some meta information (children, expressions used to evaluate, etc).

Also, allow to use identifiers for the compare value, then supply the actual value in the data source.

You can check the implementation in the dev branch here

@thomas-kl1 thomas-kl1 added the enhancement New feature or request label Jan 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants