Revert "disable save button if visualization is dirty (elastic#11576)" (

elastic#12152) This reverts commit efc6218.
thomasneirynck · Jun 12, 2017 · 537f429 · 537f429
1 parent 87e5b44
commit 537f429
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 74 deletions.
diff --git a/src/core_plugins/kibana/public/visualize/editor/editor.js b/src/core_plugins/kibana/public/visualize/editor/editor.js
@@ -113,14 +113,6 @@ function VisEditor($rootScope, $scope, $route, timefilter, AppState, $window, kb
     description: 'Save Visualization',
     template: require('plugins/kibana/visualize/editor/panels/save.html'),
     testId: 'visualizeSaveButton',
-    disableButton() {
-      return Boolean(editableVis.dirty);
-    },
-    tooltip() {
-      if (editableVis.dirty) {
-        return 'Apply or Discard your changes before saving';
-      }
-    }
   }, {
     key: 'share',
     description: 'Share Visualization',

diff --git a/test/functional/apps/visualize/_editor.js b/test/functional/apps/visualize/_editor.js
diff --git a/test/functional/apps/visualize/index.js b/test/functional/apps/visualize/index.js
@@ -22,7 +22,6 @@ export default function ({ getService, loadTestFile }) {
       });
     });
 
-    loadTestFile(require.resolve('./_editor'));
     loadTestFile(require.resolve('./_chart_types'));
     loadTestFile(require.resolve('./_gauge_chart'));
     loadTestFile(require.resolve('./_area_chart'));

diff --git a/test/functional/page_objects/visualize_page.js b/test/functional/page_objects/visualize_page.js
@@ -402,12 +402,6 @@ export function VisualizePageProvider({ getService, getPageObjects }) {
     }
 
 
-    async isSaveButtonEnabled() {
-      const saveButton = await testSubjects.find('visualizeSaveButton');
-      const clazz = await saveButton.getProperty('className');
-      return clazz.indexOf('kuiLocalMenuItem-isDisabled') === -1;
-    }
-
     saveVisualization(vizName) {
       return testSubjects.click('visualizeSaveButton')
       .then(() => {