Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server on connected events fire even after server is closed #18

Open
thomaswp opened this issue Apr 28, 2024 · 3 comments
Open

Server on connected events fire even after server is closed #18

thomaswp opened this issue Apr 28, 2024 · 3 comments
Labels
bug Something isn't working minor

Comments

@thomaswp
Copy link
Owner

If you host a game and then rehost again, in log data, I see evidence that the initialize events are still sent from the first server.

@thomaswp thomaswp added the bug Something isn't working label Apr 28, 2024
@thomaswp
Copy link
Owner Author

This may cause an immediate desync.
Server logs:
LogOutput.log

@thomaswp thomaswp added the desync The game desync label Apr 28, 2024
@thomaswp
Copy link
Owner Author

Client logs:
LogOutput.log

@thomaswp
Copy link
Owner Author

Ok, a bit of a false alarm here. It looks like issue is that right before the SingletonManager and consequently the ReplayService resets, the ReplayService reads from EventIO one last time, and therefore sets the current tick, making the logs appear like the old TimberServer was still active. This still shouldn't be happening, so I'll look into how to avoid it (e.g. saving EventIO rather than accessing it statically).

@thomaswp thomaswp removed the desync The game desync label Apr 28, 2024
@thomaswp thomaswp added the minor label Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working minor
Projects
None yet
Development

No branches or pull requests

1 participant