Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Card and Hero broken #45

Closed
1 task done
thombruce opened this issue Sep 12, 2023 · 2 comments
Closed
1 task done

[Bug]: Card and Hero broken #45

thombruce opened this issue Sep 12, 2023 · 2 comments
Assignees

Comments

@thombruce
Copy link
Owner

What happened?

Card and Hero both use the <ContentSlot> component from Nuxt Content... or they did. After migrating to a modular approach, I've replaced this with <slot /> in the core module and attempted to overwrite the components in the content module layer.

Unfortunately, whereas these used to respect the formatting of markdown within the components, they are now treating links as a new line entity. Formatting breaks.

Version

0.3.x (Default)

What browsers are you seeing the problem on?

No response

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@thombruce thombruce added the type: bug Something isn't working label Sep 12, 2023
@thombruce thombruce self-assigned this Sep 12, 2023
@thombruce
Copy link
Owner Author

These seem to be broken even when I remove the core components entirely and just leave them as they were within the components/content dir of the new content module.

Some kind of dependency conflict kind of issue maybe? We get a lot of warnings about that now, maybe unrelated.

@thombruce
Copy link
Owner Author

Note: The components unwrap the <p> element. Could that affect this? If <p> were preserved (despite the styling the complications it introduces), would it keep the content bound together?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant