New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in ws client mock - wrong close code when server not found #378

Open

easy-death opened this issue Feb 24, 2023 · 1 comment · May be fixed by #379

easy-death commented Feb 24, 2023

Current native Websocket implementation returns wasClean: false and code: 1006 when wrong url is provided.

mock-socket/src/websocket.js

Line 94 in eab4bf5

    
           this.dispatchEvent(createCloseEvent({ type: 'close', target: this, code: CLOSE_CODES.CLOSE_NORMAL }));

The text was updated successfully, but these errors were encountered:

easy-death linked a pull request

that will close this issue

fix: if server not found close code should be ABNORMAL #379

Open

Author

easy-death commented Feb 24, 2023

@Atrue could you please check, tests passing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment