Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce method for converting model to object #118

Merged
1 commit merged into from
Oct 1, 2018
Merged

Introduce method for converting model to object #118

1 commit merged into from
Oct 1, 2018

Conversation

fridex
Copy link
Contributor

@fridex fridex commented Sep 27, 2018

No description provided.

@sesheta sesheta added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 27, 2018
@todo
Copy link

todo bot commented Sep 27, 2018

add markers to the graph database

adviser/thoth/adviser/python/package_version.py

Lines 39 to 44 in 4b13b44

version = attr.ib(type=str)
develop = attr.ib(type=bool)
index = attr.ib(default=None, type=str)
hashes = attr.ib(default=attr.Factory(list))
markers = attr.ib(default=None, type=str)
_semantic_version = attr.ib(default=None, type=semver.Version)

This comment was generated by todo based on a TODO comment in 4b13b44 in #118. cc @fridex.

@ghost
Copy link

ghost commented Sep 27, 2018

Build failed.

@fridex fridex mentioned this pull request Sep 27, 2018
Closed
@sesheta sesheta added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 27, 2018
@ghost
Copy link

ghost commented Sep 27, 2018

Build failed.

@ghost
Copy link

ghost commented Sep 29, 2018

Build failed.

@ghost
Copy link

ghost commented Oct 1, 2018

Build succeeded.

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 1, 2018
@ghost
Copy link

ghost commented Oct 1, 2018

Build succeeded (gate pipeline).

@ghost ghost merged commit 6126cb6 into thoth-station:master Oct 1, 2018
@todo todo bot mentioned this pull request Oct 1, 2018
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goern goern goern approved these changes

Assignees

@fridex fridex

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fridex @goern @sesheta