Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core adviser implementation #139

Merged
merged 94 commits into from
Dec 19, 2018
Merged

Conversation

fridex
Copy link
Contributor

@fridex fridex commented Dec 19, 2018

No description provided.

@fridex fridex merged commit 5f59f25 into thoth-station:master Dec 19, 2018
@fridex fridex deleted the implementation branch December 19, 2018 10:32
@todo
Copy link

todo bot commented Dec 19, 2018

heap pop (?)

# TODO: heap pop (?)
result = (
item.get_entries()
for item in sorted(self._computed_stacks_heap, reverse=True)
)
_LOGGER.info("Filling package digests to software stacks")


This comment was generated by todo based on a TODO comment in 1342756 in #139. cc @fridex.

@todo
Copy link

todo bot commented Dec 19, 2018

Sort dependencies to have stable generations for same stacks.

# TODO: Sort dependencies to have stable generations for same stacks.
# It's important that solver preserves order in which packages were inserted.
# This is also a requirement for running under Python3.6+!!!
_LOGGER.debug("Resolving direct dependencies")
resolved_direct_dependencies = solver.solve(
list(project.iter_dependencies(with_devel=with_devel)),


This comment was generated by todo based on a TODO comment in 1342756 in #139. cc @fridex.

@todo todo bot mentioned this pull request Dec 19, 2018
@todo
Copy link

todo bot commented Dec 19, 2018

if devel and default have same packages

# TODO: if devel and default have same packages
direct_dependencies_map[package_version.name][
package_version.locked_version
][package_version.index.url] = graph_item
dependencies_map[package_name].append(graph_item)


This comment was generated by todo based on a TODO comment in 1342756 in #139. cc @fridex.

@todo
Copy link

todo bot commented Dec 19, 2018

filter out packages that do not have impact on performance

# TODO: filter out packages that do not have impact on performance
_LOGGER.info("Obtaining performance index for stack")
performance_index = self.graph.compute_python_package_version_avg_performance(
packages, hardware_specs=self.runtime_environment.to_dict()
)


This comment was generated by todo based on a TODO comment in 1342756 in #139. cc @fridex.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant