Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce prescription run to make sure each prescription reports once #2100

Merged
merged 1 commit into from
Sep 23, 2021
Merged

Introduce prescription run to make sure each prescription reports once #2100

merged 1 commit into from
Sep 23, 2021

Conversation

fridex
Copy link
Contributor

@fridex fridex commented Sep 20, 2021

Related Issues and Dependencies

Fixes: #2098

This introduces a breaking change

  • No

@fridex
Copy link
Contributor Author

fridex commented Sep 20, 2021

/hold

The testsuite needs to be extended as well as adjusted.

@sesheta sesheta added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 20, 2021
@fridex fridex changed the title Introduce prescription lock to make sure each prescription is run once WIP: Introduce prescription lock to make sure each prescription is run once Sep 20, 2021
@sesheta sesheta added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 20, 2021
@fridex fridex marked this pull request as draft September 20, 2021 08:54
@fridex fridex force-pushed the prescription-lock branch 3 times, most recently from f34d00d to 23b42bd Compare September 21, 2021 11:56
@sesheta sesheta added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 21, 2021
@fridex fridex changed the title WIP: Introduce prescription lock to make sure each prescription is run once Introduce prescription run to make sure each prescription reports once Sep 21, 2021
@fridex fridex marked this pull request as ready for review September 21, 2021 20:27
@sesheta sesheta removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 21, 2021
@fridex
Copy link
Contributor Author

fridex commented Sep 21, 2021

/retest

@fridex
Copy link
Contributor Author

fridex commented Sep 23, 2021

/assign @meile18

meile18
meile18 approved these changes Sep 23, 2021
View reviewed changes
Copy link

@meile18 meile18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fridex
Copy link
Contributor Author

fridex commented Sep 23, 2021

/approve

@sesheta
Copy link
Member

sesheta commented Sep 23, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fridex, meile18

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 23, 2021
@fridex
Copy link
Contributor Author

fridex commented Sep 23, 2021

/unhold

@sesheta sesheta removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 23, 2021
@sesheta sesheta merged commit 4b247a5 into thoth-station:master Sep 23, 2021
@fridex fridex deleted the prescription-lock branch September 23, 2021 11:27
@harshad16 harshad16 mentioned this pull request Sep 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meile18 meile18 meile18 approved these changes

@goern goern Awaiting requested review from goern goern is a code owner

@sesheta sesheta Awaiting requested review from sesheta sesheta is a code owner

@harshad16 harshad16 Awaiting requested review from harshad16

@KPostOffice KPostOffice Awaiting requested review from KPostOffice

Assignees

@meile18 meile18

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow matching only one package from multiple in prescriptions
3 participants
@fridex @sesheta @meile18