Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing dependency indexes to be checked for solver #1227

Merged
merged 2 commits into from
Feb 11, 2022

Conversation

fridex
Copy link
Contributor

@fridex fridex commented Feb 9, 2022

Related Issues and Dependencies

Related: thoth-station/solver#5111
Related: thoth-station/graph-refresh-job#669
Related: thoth-station/thoth-application#2272

This introduces a breaking change

  • No

Description

Allow passing new environment variable for solvers, which would check indexes for possible dependencies (cross-index resolution).

@fridex
Copy link
Contributor Author

fridex commented Feb 9, 2022

/hold

@sesheta sesheta added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 9, 2022
@fridex fridex marked this pull request as draft February 9, 2022 17:36
@sesheta sesheta added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 9, 2022
@fridex fridex marked this pull request as ready for review February 11, 2022 08:33
@sesheta sesheta removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 11, 2022
@fridex
Copy link
Contributor Author

fridex commented Feb 11, 2022

/unhold
/assign @pacospace

Ready to be reviewed.

@sesheta sesheta removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 11, 2022
Copy link
Contributor

@pacospace pacospace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Thanks! 💯 Please have a look at prow failures

@sesheta
Copy link
Member

sesheta commented Feb 11, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pacospace

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 11, 2022
@sesheta sesheta merged commit 2609b4c into thoth-station:master Feb 11, 2022
@fridex fridex deleted the dependency-indexes branch February 11, 2022 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants