Send messages based on template defaults, do not hardcode #1231
Conversation
sesheta
added
the
size/XS
|
/assign @har |
|
@fridex: GitHub didn't allow me to assign the following users: har. Note that only thoth-station members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assign @harshad16 |
thoth/common/openshift.py
Outdated
| template_parameters["THOTH_SEND_MESSAGES"] = str( | ||
| int(specification["send_messages"]) | ||
| ) | ||
|
|
||
| template_parameters["THOTH_FORCE_SYNC"] = str( |
There was a problem hiding this comment.
The same should be done here for THOTH_FORCE_SYNC
|
/assign @fridex |
sesheta
added
size/S
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: harshad16, KPostOffice The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Related Issues and Dependencies
We should not hardcode this behavior, rather have it configurable on the template level.