Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify container image feature to check for 404, see #348 #351

Merged
merged 1 commit into from
Oct 18, 2022

Conversation

goern
Copy link
Member

@goern goern commented Oct 18, 2022

solves #348

Signed-off-by: Christoph Görn goern@redhat.com



Signed-off-by: Christoph Görn <goern@redhat.com>
@sesheta sesheta added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 18, 2022
Copy link
Contributor

@mayaCostantini mayaCostantini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@sesheta
Copy link
Member

sesheta commented Oct 18, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mayaCostantini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 18, 2022
@sesheta sesheta merged commit c7a28bf into thoth-station:main Oct 18, 2022
@goern goern deleted the issue/thamos/1184 branch October 19, 2022 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants