Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically update the base image version for new container images #991

Closed
mayaCostantini opened this issue Feb 4, 2022 · 11 comments
Closed
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/accepted Indicates an issue or PR is ready to be actively worked on. triage/needs-information Indicates an issue needs more information in order to work on it.

Comments

@mayaCostantini
Copy link

Is your feature request related to a problem? Please describe.
We would like to have an automatic update of the base image used to build our container images to the latest version available on Quay. See:

Describe the solution you'd like
Implement a new manager to update automatically the base image version based on what is available on Quay (see: #847 for a similar example). This could be implemented as part of Kebechet or as a new service.

Or: add a Tekton event listener to trigger the update when a new version of the base image is released.

Describe alternatives you've considered
Do the change manually.

@mayaCostantini mayaCostantini added kind/feature Categorizes issue or PR as related to a new feature. triage/needs-information Indicates an issue needs more information in order to work on it. labels Feb 4, 2022
@sesheta sesheta added the needs-triage Indicates an issue or PR lacks a `triage/...` label and requires one. label Feb 4, 2022
@mayaCostantini
Copy link
Author

/priority important-longterm

@sesheta sesheta added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Feb 4, 2022
@codificat
Copy link
Member

Is this a duplicate of thoth-station/core#359?

@goern
Copy link
Member

goern commented Feb 4, 2022

Is this a duplicate of thoth-station/core#359?

Ja! You found it, I was not able to find it :/

It might indeed be a subset/overlap

@mayaCostantini
Copy link
Author

/close
Duplicate (subset) of thoth-station/core#359

@sesheta
Copy link
Member

sesheta commented Feb 4, 2022

@mayaCostantini: Closing this issue.

In response to this:

/close
Duplicate (subset) of thoth-station/core#359

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sesheta sesheta closed this as completed Feb 4, 2022
@fridex
Copy link
Contributor

fridex commented Feb 4, 2022

/close Duplicate (subset) of thoth-station/core#359

I think we could rethink this a bit. The referenced issue talks about bumping the base image used in .aicoe-ci.yaml - like in thoth-station/user-api#1657 I think that is one use case we could implement as discussed in the referenced issue.

Another one could be about automatic bumps in thoth-application - like in thoth-station/thoth-application#2316 This could be a different implementation that would automatically open pull requests based on built container images (it can be a standalone cronjob or part of aicoe-ci.yaml configuration and let AICoE-CI open pull requests once container images are built). During the release cycle, we could just /approve whatever we see should be populated to the stage environment and eventually prod (if we do not want to keep bulk bumps as done in thoth-station/thoth-application@afff34f, worth discussing). Anyway, this would automate propagating container images to environments (at least stage) and would reduce anoying burden to open "Bump <component> to version <version> to stage" and the need for checking if built container images are available as in thoth-station/thoth-application#2313 (comment) (prone to errors).

@fridex
Copy link
Contributor

fridex commented Feb 4, 2022

Let's talk about this on the next tech talk. Until then,

/reopen

@sesheta
Copy link
Member

sesheta commented Feb 4, 2022

@fridex: Reopened this issue.

In response to this:

Let's talk about this on the next tech talk. Until then,

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sesheta sesheta reopened this Feb 4, 2022
@harshad16
Copy link
Member

Action Items:

  • Discuss in the ADR on core repo about the solution.
  • Proposed plan based on "Lets talk Thoth" calls was to have a separate script:
    • Develop a python script to bump base image in pipeline-helper repo.
    • Have the script modular, let it take input file (ex: .aicoe-ci.yaml, .thoth.yaml) and bump base image based on the input file.

Building block for bump image:

Block 1:
push event choice repo , 
input file, cloned repo 

Block 2
the script receives the input file, cloned repo
API to quay for checking the latest version
Verison Bump  

Block3 
open pr and some detail in pr description 

Useful resources:
https://docs.quay.io/api/swagger/
https://github.com/AICoE/aicoe-ci

Event Trigger:

  • should we have it triggered by quay API?
  • should we have it triggered by GitHub webhook on push event(only on active repos)?

@goern
Copy link
Member

goern commented Feb 15, 2022

/triage accepted

@mayaCostantini
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/accepted Indicates an issue or PR is ready to be actively worked on. triage/needs-information Indicates an issue needs more information in order to work on it.
Projects
None yet
Development

No branches or pull requests

6 participants