-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add script to bump base image versions to latest #45
Add script to bump base image versions to latest #45
Conversation
1710bdf
to
6815ff2
Compare
@harshad16 PTAL 👍🏻 |
6815ff2
to
a673e92
Compare
What about having this as a feature of AICoE-CI - similarly as it bumps versions for test environment, it could bump also |
That is the plan, instead of embedding the code in the tekton task, the idea here is to have this script invoked in the tekton task.In this way, if we every decide on moving it to kebechet this might help us also if anyone wants to use this code can import in their workflow. |
is this good to be merged? |
@goern It hasn't been reviewed yet, @harshad16 could you PTAL? 👍🏻 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
this is amazing
sorry for the delay in review
lets address , few of the below concern and we are ready for merge.
Thanks for the review @harshad16 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the changes 💯
pls add the authentication in another pr.
reference: https://docs.quay.io/api/
set token from env var, we can supply that env var from the pipeline
moving a ahead with this pr and creating a new image from this.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: harshad16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Related Issues and Dependencies
Related to thoth-station/kebechet#991
More precisely: thoth-station/kebechet#991 (comment)
This introduces a breaking change
This Pull Request implements
Add a script to automatically bump the base image versions of a repository configuration file in a modular way based on content available on Quay.