Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add script to bump base image versions to latest #45

Merged

Conversation

mayaCostantini
Copy link
Contributor

Related Issues and Dependencies

Related to thoth-station/kebechet#991
More precisely: thoth-station/kebechet#991 (comment)

This introduces a breaking change

  • No

This Pull Request implements

Add a script to automatically bump the base image versions of a repository configuration file in a modular way based on content available on Quay.

@sesheta sesheta added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 16, 2022
@mayaCostantini mayaCostantini force-pushed the bump-base-image-version-script branch 2 times, most recently from 1710bdf to 6815ff2 Compare February 16, 2022 12:54
@mayaCostantini
Copy link
Contributor Author

@harshad16 PTAL 👍🏻

@fridex
Copy link
Contributor

fridex commented Feb 16, 2022

What about having this as a feature of AICoE-CI - similarly as it bumps versions for test environment, it could bump also base_image as expected?

@harshad16
Copy link
Member

What about having this as a feature of AICoE-CI - similarly as it bumps versions for test environment, it could bump also base_image as expected?

That is the plan, instead of embedding the code in the tekton task, the idea here is to have this script invoked in the tekton task.In this way, if we every decide on moving it to kebechet this might help us also if anyone wants to use this code can import in their workflow.

@goern
Copy link
Member

goern commented Mar 9, 2022

is this good to be merged?

@mayaCostantini
Copy link
Contributor Author

@goern It hasn't been reviewed yet, @harshad16 could you PTAL? 👍🏻

Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
this is amazing
sorry for the delay in review

lets address , few of the below concern and we are ready for merge.

bump_base_image_version.py Outdated Show resolved Hide resolved
bump_base_image_version.py Outdated Show resolved Hide resolved
bump_base_image_version.py Outdated Show resolved Hide resolved
bump_base_image_version.py Show resolved Hide resolved
@mayaCostantini
Copy link
Contributor Author

Thanks for the review @harshad16 🚀
Changes were added in ea3a3ec, I can also fix the authentication issue in this PR directly if needed, let me know what you think is best 👍🏻

Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the changes 💯

pls add the authentication in another pr.
reference: https://docs.quay.io/api/

set token from env var, we can supply that env var from the pipeline
moving a ahead with this pr and creating a new image from this.

@sesheta
Copy link
Member

sesheta commented Mar 14, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 14, 2022
@sesheta sesheta merged commit 34fb310 into thoth-station:master Mar 14, 2022
@mayaCostantini mayaCostantini deleted the bump-base-image-version-script branch March 14, 2022 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants