added build from git option

[Gkrumbach07]

Related Issues and Dependencies

fixes: #11

This introduces a breaking change

• No

This should yield a new module release

• Yes

This Pull Request implements

Creates the import from git repo option

Description

[codificat]

Some small changes needed, as git ref is optional.

Besides that, maybe rebase from current main? There's no merge conflict, but as the rebase included a bunch of commits, a rebase (which should be trivial without conflict) would make for a slightly cleaner history.

As a side note: when testing this I noticed that the current version of the controller / pipeline for the gitRepo build type is not working - but that will be a separate story.

[codificat]

/deploy

[codificat]

I tested the latest version and it
/lgtm
/approve
thanks!

The dashboard looks good, and it interacts with CREs correctly.

I still have not managed to make it work end to end due to thoth-station/meteor-operator#162

Maybe by the time CI (prow) is back to handle tests and merging, e2e will be ready :)

[codificat]

The dashboard looks good, and it interacts with CREs correctly.

Unfortunately I have to correct: now that I did manage to test the PR end to end, I found that when the pipeline succeeds and the CRE is flagged as Succeeded, the interface shows it as Failed.

Thinking that it was something still missing / wrong in the gitRepo build type from the CRE/pipeline, I tested this with an imageImport build type and I saw the same behaviour:

there seems to be something here that breaks correct status reporting at the end of the process - I couldn't spot it at first sight though

[codificat]

there seems to be something here that breaks correct status reporting at the end of the process - I couldn't spot it at first sight though

Gage helped clarify that this comes from an inconsistency in the controller: thoth-station/meteor-operator#169

From the dashboard point of view, this works as expected.

/lgtm
/approve

[sesheta]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: codificat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [codificat]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codificat]

/retest