Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup overlays directory in .thoth.yaml #24

Merged
merged 1 commit into from
Aug 16, 2021

Conversation

fridex
Copy link
Contributor

@fridex fridex commented Aug 16, 2021

Related Issues and Dependencies

Fixes: thoth-station/thamos#906

This introduces a breaking change

  • No

@sesheta sesheta added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 16, 2021
Copy link
Contributor

@pacospace pacospace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!! 💯

@sesheta
Copy link
Member

sesheta commented Aug 16, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pacospace

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 16, 2021
@sesheta sesheta merged commit 5e21e3b into thoth-station:master Aug 16, 2021
@fridex fridex deleted the overlays-dir branch August 16, 2021 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot run thamos advise when there are overlays
3 participants