[3pt][SPIKE] verify kebechet's advise manager is working on all overlays

[goern]

High-level Goals
verify kebechet's advise manager is working on all overlays

Acceptance Criteria

• all the overlay directories should have up to date Pipefile/Pipefile.lock based on Thoth's current production data.
• identify list of actions/issues if problems are present (like data is outdated, ...)

[codificat]

A pre-requisite for this is thoth-station/core#326

/sig user-experience
/triage accepted
/priority important-soon

[codificat]

fixing duplicate priorities here:
/remove-priority important-soon

[harshad16]

When kebechet advise is being triggered via issue.
the log shows:

2022-07-08 14:57:28,973   1 INFO     kebechet:196: Running manager 'thoth-advise' for 'thoth-station/ps-nlp'
2022-07-08 14:57:30,562   1 DEBUG    kebechet.managers.thoth_advise.thoth_advise:305: No issue found to start advises for.

kebechet-job-220708145721-42be33530d896d11-980726572-main.log

seems like it unable to find the issue in the repo #156 .
that seems to be the issue.

[harshad16]

update seems like we need to use the case-sensetive title.
https://github.com/thoth-station/kebechet/blob/4b658e4f6ea36a7bed2e89c4efd6adc476685482/kebechet/managers/thoth_advise/thoth_advise.py#L62

with the new issue: #157
it seems like the adviser worked on the issue, however, the kebechet only submit the analysis and don't wait for the result.

• kebechet should wait for the result and update the prs.

kebechet-job-220708152239-def7889814748097-3532633137-main.log

Another issue is:

• if the push event is allowed to trigger adviser, maybe that is the reason why thoth-advise is not being triggered regularly.

[harshad16]

• seems like the kebechet-run-results are not working:

STEP                                      TEMPLATE                                   PODNAME                                           DURATION  MESSAGE
 ✖ adviser-220708152257-92041d31ab35d227  adviser                                                                                                                         
 ├─✔ advise                               advise/advise                              adviser-220708152257-92041d31ab35d227-2745043324  21m                                
 ├─✔ graph-sync-advise(0)                 graph-sync/graph-sync                      adviser-220708152257-92041d31ab35d227-3249686578  15s                                
 ├─✔ parse-adviser-output                 parse-adviser-output/parse-adviser-output  adviser-220708152257-92041d31ab35d227-3229721138  9s                                 
 ├─✔ trigger-integration                  trigger-integration/trigger-integration    adviser-220708152257-92041d31ab35d227-144062123   8s                                 
 ├─✖ kebechet-run-results                 kebechet-run-results/schedule-kebechet     adviser-220708152257-92041d31ab35d227-3931961412  8s        failed with exit code 2  
 └─✔ send-messages                        send-messages/send-messages                adviser-220708152257-92041d31ab35d227-2190378065  5s

The kebechet-run-result has issues:

Usage: kebechet-cli run-results [OPTIONS]
Try 'kebechet-cli run-results --help' for help.

Error: Missing option '-m' / '--thoth-adviser-metadata'.

[shreekarSS]

While testing creation of 'Kebechet Advise ' issue to get thamos advise,
I faced this permission issue shreekarSS#6 (comment)
So I added myself as a owner to test and opened thoth-station/kebechet#1081, the way kebechet reading the it's own OWNER file than reading the OWNERS from cloned repo

[harshad16]

The kebechet-run-result is able to process a little bit ahead
however it fail on resolving through the result of adviser.
issue: thoth-station/support#244
adviser-220711150929-55d0d75149b291c3-2643566434-main.log

[harshad16]

Fixing this comment would fix the issue:
thoth-station/support#244 (comment)

[harshad16]

The kebechet thoth-advise is unable to parse the result and share the output a PR.
The reason is due to the formatting. As result of the thamos get_analysis_results is a tuple with (result, error_boolean)
https://github.com/thoth-station/kebechet/blob/536cf1ca02c933e11c1f5ddea0a3d659964f955b/kebechet/managers/thoth_advise/thoth_advise.py#L390
The result formatting needs to be rechecked.

Tasks to do:

• Familiarize through kebechet thoth-advise code base and thamos lib code base.
• Figure out what formatting is out of order and where all to change source code, to fit to the latest thamos.
• Update kebechet thoth-advise code base with suitable changes.
• If changes, are required on thamos end, open a issue in thamos with proper details and proposal.
  • work on creating the thamos end source code.
• Open PR for review

The process to test in local:
The focus part is kebechet output retrieved from adviser, which is handled by kebechet run-result

Required params example:

KEBECHET_REPO_URL = "https://github.com/thoth-station/ps-nlp"
KEBECHET_SERVICE_NAME= "github"
KEBECHET_ANALYSIS_ID = "adviser-220715024124-598c498944fcb667"
THOTH_ADVISER_METADATA="{"origin": "https://github.com/thoth-station/ps-nlp", "re_run_adviser_id": null, "source_type": "KEBECHET", "kebechet_metadata": null, "thoth.adviser": {"justification": null, "stack_info": null}}"

Follow a similar pattern and try out different analysis id while working on this.
Different analysis ids can be found here in comments: #160

[shreekarSS]

FYI thoth-station/kebechet#1094