-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue: Kebechet was picking approvers from it's own OWNERS file #1081
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
checking ownership is a good thing, so lets keep it and fix issue regarding it.
e1f9332
to
2089ded
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems like the comment are still left
2089ded
to
a21ca04
Compare
a21ca04
to
6a5dc86
Compare
Fix: To pick approvers from CLONED repo Signed-off-by: Shreekar <sshreeka@redhat.com>
6a5dc86
to
0bb79f6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just one question
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
thanks 💯
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: harshad16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fix: To pick approvers from CLONED repo
Related Issues and Dependencies
thoth-station/ps-nlp#151
shreekarSS/ps-nlp#5
Description
Kebechet will pull the approvers list from the cloned repository rather than its own OWNERS file.