Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Max to approvers #2714

Merged
merged 1 commit into from
Sep 30, 2022
Merged

Add Max to approvers #2714

merged 1 commit into from
Sep 30, 2022

Conversation

mayaCostantini
Copy link
Contributor

This introduces a breaking change

  • No

This should yield a new module release

  • No

@sesheta sesheta added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 21, 2022
harshad16
harshad16 approved these changes Sep 30, 2022
View reviewed changes
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/apporve
thanks 💯

@sesheta sesheta added the lgtm Indicates that a PR is ready to be merged. label Sep 30, 2022
@sesheta
Copy link
Member

sesheta commented Sep 30, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 30, 2022
@sesheta sesheta merged commit 65cfbfc into thoth-station:master Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshad16 harshad16 harshad16 approved these changes

@KPostOffice KPostOffice Awaiting requested review from KPostOffice

@VannTen VannTen Awaiting requested review from VannTen

Assignees

@harshad16 harshad16

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mayaCostantini @sesheta @harshad16