Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs sync, take 2 #2758

Merged
merged 1 commit into from
Jan 18, 2023
Merged

Fix docs sync, take 2 #2758

merged 1 commit into from
Jan 18, 2023

Conversation

VannTen
Copy link
Member

@VannTen VannTen commented Jan 18, 2023

followup to #2751
it's an ugly hack but it should work'

@sesheta sesheta added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 18, 2023
@codificat
Copy link
Member

it's an ugly hack but it should work'

Agreed.
/lgtm
/approve

@sesheta sesheta added the lgtm Indicates that a PR is ready to be merged. label Jan 18, 2023
@sesheta
Copy link
Member

sesheta commented Jan 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: codificat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 18, 2023
@sesheta sesheta removed the lgtm Indicates that a PR is ready to be merged. label Jan 18, 2023
This is an ugly hack to get match the handlers without re-factoring the
dispacthing code (to each handler).
@VannTen
Copy link
Member Author

VannTen commented Jan 18, 2023 via email

@codificat
Copy link
Member

/lgtm

@sesheta sesheta added the lgtm Indicates that a PR is ready to be merged. label Jan 18, 2023
@sesheta sesheta merged commit 2869066 into thoth-station:master Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants