Enabled abbreviation syntax for subrepos, ticket 386 #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterebden
reviewed
Aug 15, 2018
docs/subrepos.html
Outdated
| <p>If the subrepo and the package names are the same, for example, <code>@unittest_cpp//:unittest_cpp</code>, | ||
| the build label reference to the target can be abbreviated, like so:</p> | ||
|
|
||
| <pre><code>subinclude("@pleasings//go:go_bindata") |
There was a problem hiding this comment.
remove the subinclude bit, it's not really germane to the example
src/core/build_label_test.go
Outdated
| targetNewSyntax := "@unittest_cpp" | ||
| pkg, name, subrepo := parseBuildLabelParts(target1, "/", nil) | ||
| pkg2, name2, subrepo2 := parseBuildLabelParts(targetNewSyntax, "/", nil) | ||
| assert.Equal(t, pkg, pkg2) |
There was a problem hiding this comment.
probably better to assert the values directly; technically you could pass this test with an implementation that always returned "" for the subrepo for example.
added 2 commits
August 15, 2018 10:34
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@unittest_cpp//:unittest_cppcan be shortened to@unittest_cppsubreposection