Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Padding and margin-bottom for forms is missing unit #99

Closed
mm53bar opened this issue Sep 9, 2014 · 1 comment
Closed

Padding and margin-bottom for forms is missing unit #99

mm53bar opened this issue Sep 9, 2014 · 1 comment

Comments

@mm53bar
Copy link

mm53bar commented Sep 9, 2014

My forms didn't look as pretty as the examples on the bitters site. It looks like Chrome didn't like the calculated padding and margin-bottom because it was missing the em unit.

I changed lines 40 & 41 in _forms.scss from this:

 margin-bottom: $base-line-height / 2;
 padding: ($base-line-height / 3) ($base-line-height / 3);

to this:

 margin-bottom: #{$base-line-height / 2}em;
 padding: #{$base-line-height / 3}em #{$base-line-height / 3}em;

and everything seems OK now. If this makes sense to you then I can submit a pull request.

@tysongach
Copy link
Contributor

Hi Michael,

We recently made a change which makes the $base-line-height variable unit-less and added a $base-spacing variable which does have a unit and can be used for common, reusable spacing. The latest version of Bitters uses $base-spacing for the margins and padding on form elements. It’s likely that you have an out-of-date version, around when we were making these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants