Allow ignoring of SSL certificate warnings #152
Conversation
This variable is used by people together with webdriver to ignore warnings when using self signed certificates. This workaround should fix the issue #16 for people doing remote testing with a http to https redirect.
| @@ -8,12 +8,29 @@ NetworkAccessManager::NetworkAccessManager(QObject *parent):QNetworkAccessManage | |||
|
|
|||
| QNetworkReply* NetworkAccessManager::createRequest(QNetworkAccessManager::Operation oparation, const QNetworkRequest &request, QIODevice * outgoingData = 0) { | |||
| QNetworkRequest new_request(request); | |||
|
|
|||
| // emulate Firefox, allowing to disable certificate | |||
There was a problem hiding this comment.
I prefer breaking out into self-describing methods to using comments.
|
Thanks for the patch. I had a couple comments on the code. Also, capybara-webkit is 100% test-driven, so we'd need a test verifying that this works correctly. |
|
I will look at the comments. Thanks. What kind of test are you expecting? This works for remote testing, so a test will mean embedding a webserver that supports SSL and making a connection during the test. If that is ok... |
|
I am not very familiar with how the Capybara driver interface is. It receives a Rack app directly in the constructor, and it is Capybara who does the work of giving the driver a "remote" rack app. I could try to simulate this using Webrick with SSL in the testcase. If you know an easier way, let me know. |
This variable is used by people together with Firefox/webdriver to ignore warnings when using self signed certificates.
This workaround should fix the issue #16 for people doing remote testing with a http to https redirect.
I dont have a test yet. I am not sure ow this can be tested with a rack app, as the bugs shows up when using Capybara.app_host with remote testing. Ideas for a test welcomed.
Also I havent documented it yet, but if the README.md is ok, I can add it.