This repository has been archived by the owner on Mar 3, 2020. It is now read-only.
Qt 4.8 compatibility #403
Merged
Qt 4.8 compatibility #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| src/debug | ||
| webkit_server.pro.user |
There was a problem hiding this comment.
What's this for? I'm fine having it; I'm just curious.
There was a problem hiding this comment.
I set up QtCreator to assist with debugging, and it dropped a webkit_server.pro.user file with my IDE preferences in the root.
|
That's a shame about the timeout issue, but I'm willing to live without it for now. If I understand correctly, with these changes, everything is passing without segfaults on both Qt 4.7 and 4.8? Awesome work. |
|
Oh, this is good to merge. |
This reverts commit da93136. Conflicts: src/TimeoutCommand.cpp
|
I left the malloc spec running overnight and it was green when I woke up. I think we've squashed the bulk of the issues. Still not sure why we're getting segfaults when running in valgrind, but they're present with 4.7.4 as well. |
ghost
mentioned this pull request
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've tested these changes against Qt 4.7.4 and 4.8.2 on Linux.
I had to revert da93136 as it was causing a segfault on Qt 4.8.