-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Errors and Exceptions should not be silently piped to an unreachable log file on Heroku #82
Comments
@johnmcdowall I think instead it'd be better to just remove the silence altogether. [EDIT] if you'd like to do a PR just let me know, otherwise I'll work on it sometime this weekend. |
@johnmcdowall Started working on this. Turns out we did this to avoid this gnarly output (EDIT: in test): We are likely going to make silencing this stream optional. Will post more when I know. |
@johnmcdowall Thanks 🍻 |
@rondale-sc Great work, thanks! 👍 |
In
app.rb
the output from executing the Ember-CLI build is silently piped to a log file:https://github.com/rwz/ember-cli-rails/blob/master/lib/ember-cli/app.rb#L18
This is bad on Heroku, because it looks like the build succeeds and causes a downstream exception to be raised in Sprockets because the files it was told to expect don't exist because of the build failure. In general this is a bad thing™ to do. It is also a violation of the 12factor application principles with regard to logging:
There are two ways I see to addressing this:
Happy to make PRs with the relevant changes if open to them.
The text was updated successfully, but these errors were encountered: